Re: PATCH: make ar emitt a warning if an archive is created (POSIX)

[Nick Clifton]

Hi Tobias,

> this is item (c) on my `make ar POSIX conform` list:
>   http://sources.redhat.com/ml/bug-binutils/2003-q4/msg00014.html

Approved and applied.

A couple of notes:


> Index: ChangeLog
> ===================================================================
> RCS file: /cvs/src/src/binutils/ChangeLog,v
> retrieving revision 1.711

Please do not include the ChangeLog entry as a context diff.  Instead
please just use straight text.  This is because the ChangeLog files
are being updated so frequently that a patch against them can almost
never be applied.


>        arch = bfd_openw (archive_filename, target);
> +      if (!silent_create)
> +        non_fatal (_("creating %s"), archive_filename);
> +
>        if (arch == NULL
>         || ! bfd_set_format (arch, bfd_archive)
>         || ! bfd_close (arch))

I moved your new code to after the "if (arch == NULL...." statement so
that the message about creating an archive is only emitted if the
archive is actually going to be created.

Cheers
        Nick