[Bug binutils/2159] New: unused parameters `cursig' and `gregs' in bfd/elf.c (elfcore_write_pstatus)

[mbanck at debian dot org]

binutils/bfd fails to build on GNU/Hurd with the following error (this is Debian
unstable source, version 2.16.1cvs20051214):

gcc -DHAVE_CONFIG_H -I. -I../../bfd -I. -I. -I../../bfd -I../../bfd/../include
-I../../bfd/../intl -I../intl -W -Wall -Wstrict-prototypes -Wmissing-prototypes
-Werror -g -O2 -c ../../bfd/elf.c  -fPIC -DPIC -o .libs/elf.o
cc1: warnings being treated as errors
../../bfd/elf.c: In function 'elfcore_write_pstatus':
../../bfd/elf.c:7895: warning: unused parameter 'cursig'
../../bfd/elf.c:7896: warning: unused parameter 'gregs'
make[5]: *** [elf.lo] Error 1

${includedir}/sys/procfs.h has this:

struct elf_pstatus
{
  int pr_flags;                 /* Meaningless flags bits.  */
  int pr_nlwp;                  /* Number of threads in this process.  */
  pid_t pr_pid;                 /* Process ID.  */
  pid_t pr_ppid;                /* Parent's process ID.  */
  pid_t pr_pgid;                /* Process group ID.  */
  pid_t pr_sid;                 /* Session ID.  */
  struct timespec pr_utime;     /* User CPU time used by this process.  */
  struct timespec pr_stime;     /* System CPU time used by this process.  */
  struct timespec pr_cutime;    /* User CPU time used by dead children.  */
  struct timespec pr_cstime;    /* System CPU time used by dead children.  */
};
typedef struct elf_pstatus pstatus_t;

So I believe the two parameters should get purged from elfcore_write_pstatus()
to make bfd build with -Werror.

-- 
           Summary: unused parameters `cursig' and `gregs' in bfd/elf.c
                    (elfcore_write_pstatus)
           Product: binutils
           Version: 2.16
            Status: NEW
          Severity: normal
          Priority: P2
         Component: binutils
        AssignedTo: unassigned at sources dot redhat dot com
        ReportedBy: mbanck at debian dot org
                CC: bug-binutils at gnu dot org
 GCC build triplet: i686-unknown-gnu0.3
  GCC host triplet: i686-unknown-gnu0.3
GCC target triplet: i686-unknown-gnu0.3


http://sourceware.org/bugzilla/show_bug.cgi?id=2159

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.