Re: another -Werror failure during build binutils-2.17

[anirkko]

Hi again.

Interesting, gcc-4.1.2 seems to discover initialization problems
even across function calls, triggering another -Werror failure in
build of binutils-2.17:

In file binutils/wrstabs.c the initialization is lacking in stab_tag_type(),
and the compiler tells us this, but points out line 1297 which is in a
different function, where size can be used uninitialized (in the form of *psize)

If I initialize size with 0 in stab_tag_type(), building continues. I assume
that this is what would happen anyway if the warning was not detected. Still,
I don't know if there also, a real problem could be triggered depending on
input...?

Greetings,
Arto

-----------------------------------------------------------------------------
...
...
gcc -DHAVE_CONFIG_H -I. -I/build/binutils-2.17/binutils -I. -D_GNU_SOURCE -I. 
-I/build/binutils-2.17/binutils -I../bfd -I/build/binutils-2.17/binutils/../bfd 
-I/build/binutils-2.17/binutils/../include 
-I/build/binutils-2.17/binutils/../intl -I../intl 
-DLOCALEDIR="\"/usr/local/static/gcc/binutils-2.17/share/locale\"" 
-Dbin_dummy_emulation=bin_vanilla_emulation   -W -Wall -Wstrict-prototypes 
-Wmissing-prototypes -Werror -O3 -mcpu=supersparc  -c 
/build/binutils-2.17/binutils/wrstabs.c
cc1: warnings being treated as errors
/build/binutils-2.17/binutils/wrstabs.c: In function 'stab_tag_type':
/build/binutils-2.17/binutils/wrstabs.c:1297: warning: 'size' is used 
uninitialized in this function
gmake[4]: *** [wrstabs.o] Error 1
gmake[4]: Leaving directory 
`/build/binutils-2.17_obj0-static_g412-b214-O3-mcpu=supersparc/binutils'
gmake[3]: *** [all-recursive] Error 1
...
...