Re: binutils-2.19 -- source tarball may be incomplete or inconsistent

[Nick Clifton]

Hi Keith,

> Strangely, although I 
> didn't preserve the generated `deffilep.h', and it now appears 
> nowhere in either the source or the build tree, its absence doesn't 
> seem to affect the success of the build; is it a quirk of building 
> for the `mingw32' target, that it isn't required, or is it just 
> superfluous?

Weird.  It is included by ld/pe-dll.[ch] which are used by the 
i386-mingw32 target, so I would have expected your build to complain. 
Possibly there is a missing dependency in the Makefile so that pe-dll.o 
does not know that it needs the deffile.h header.


> I plan to repackage binutils-2.19, for redistribution from the MinGW 
> site on SourceForge, and I would like to save other users from the 
> problems I have experienced.  Presumably:
>
>   * rescheduling the timestamps for bfd/doc/{elf.texi,bfd.info}
>   * adding ld/deffilep.c
>
> are appropriate.

Agreed.


>  Should I also add ld/deffilep.h?

Yes I think so.

Cheers
  Nick