Re: binutils-2.21.53 bugs

[Nick Clifton]

Hi Jorma,

> #: addr2line.c:271
> #, c-format
> msgid " at "
>
> Is this "at" an address or a function or something? It is difficult to
> translate due to missing context.

It refers to a line number/file name pair that is contains the function 
name that has just been displayed.  For example:

  foo at 123:bar.c


> #: addr2line.c:296
> #, c-format
> msgid " (inlined by) "
>
> by who ? Missing context here too.

By the line number/file name pair that is about to be displayed (by the 
next iteration of the while loop).  For example:

   123:bar.c (inlined by) 456:main.c

Or, if function names are being displayed as well:

  foo at 123:bar.c (inlined by) main at 456:main.c

I have placed a couple of comments to this effect into the code.


> ar.c:1024
>      bfd_fatal ("could not create temporary file whilst writing archive");

Now fixed.


> bucomm.c:228
>      case BFD_ENDIAN_BIG: return _("big endian");
> bucomm.c:229
>      case BFD_ENDIAN_LITTLE: return _("little endian");
> bucomm.c:230
>      default: return _("endianness unknown");

Also fixed.


> bucomm.c:251
>        printf (_("%s\n (header %s, data %s)\n"), p->name,

Done.


> I wonder, if setlocale could be used here:
>
> bucomm.c:430
>           const char *ctime_result = (const char *) ctime (&when);
>
>           /* POSIX format:  skip weekday and seconds from ctime output.  */
>           sprintf (timebuf, "%.12s %.4s", ctime_result + 4, ctime_result + 20);

I not think that ctime is influenced by the locale.  It would be better 
perhaps to use the strftime function instead.



> coffdump.c:130
>    printf (_("size %d "), p->size);
[...]
> sysdump.c:66
>      return _("*undefined*");
[...]
> dlltool.c:1266
>        printf (_("VERSION %d.%d\n"), major, minor);
[...]
> dllwrap.c:417
>        warn (_("wait: %s"), strerror (errno));
[...]
> dwarf.c:132
>        error (_("Wrong size in print_dwarf_vma"));
[...]
> #: readelf.c:4057 readelf.c:4132
> msgid "symtab shndx"<--- PLS, REMOVE THIS _(ONE) ??
[...]

The issues in these files should now be resolved.

Cheers
  Nick Clifton

binutils/ChangeLog
2011-10-13  Nick Clifton  <address@hidden>

        Fixes to aid translation:
        * addr2line.c (translate_address): Add comments describing context
        of a couple of printf statements.
        * ar.c (write_archive): Allow translation of error message.
        * bucomm.c (endian_string): Allow translation of strings.
        (display_target_list): Allow translation.
        * coffdump.c (dump_coff_type): Allow translation of output.
        (dump_coff_where): Likewise.
        (dump_coff_symbol): Likewise.
        (dump_coff_scope): Likewise.
        (dump_coff_sfile): Likewise.
        (dump_coff_section): Likewise.
        (coff_dump): Likewise.
        * dlltool (def_version): Allow translation of output.
        (run): Likewise.
        * dllwrap.c (run): Allow translation of output.
        * dwarf.c (print_dwarf_vma): Allow translation of output.
        (process_extended_line_op): Remove spurious translation.
        Add translation for strings that can be translated.
        (decode_location_exression): Allow translation of output.
        (read_and_display_attr_value): Allow translation of output.
        * readelf.c (slurp_rela_relocs): Add translation for error
        messages when failing to get data.
        (slurp_rel_relocs): Likewise.
        (get_32bit_elf_symbols): Likewise.
        (get_64bit_elf_symbols): Likewise.
        (dump_ia64_vms_dynamic_relocs): Replace abbreviation with full
        word.
        (process_relocs): Remove spurious translation.
        (decode_tic6x_unwind_bytecode): Likewise.
        (process_version_section): Improve error messages.
        (process_mips_specific): Likewise.
        (print_gnu_note): Remove spurious translation.
        (print_stapsdt_note): Likewise.
        (get_ia64_vms_note_type): Likewise.
        * sysdump.c (getCHARS): Allow translation.
        (fillup): Allow translation of output.
        (getone): Likewise.
        (must): Likewise.
        (derived_type): Likewise.
        * doc/binutils.doc (addr2line): Extend description of command line
        options.
        * po/binutils.pot: Regenerate.