[Bug binutils/19518] readelf - missing return value check in MIPS timestamp d_tag processing

[nickc at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19518

Nick Clifton <nickc at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |nickc at redhat dot com
         Resolution|---                         |DUPLICATE

--- Comment #1 from Nick Clifton <nickc at redhat dot com> ---
(In reply to vpb from comment #0)

>         tmp = gmtime (&atime); 
>         snprintf (timebuf, sizeof (timebuf), "%04u-%02u-%02uT%02u:%02u:%02u",

> Since tmp can be NULL if atime is invalid, the subsequent snprintf() call
> results in a segmentation fault. 

This has already been fixed in 2.25 and later releases of binutils.  The
relevent code now looks like:

        tmp = gmtime (&atime);
        /* PR 17531: file: 6accc532.  */
        if (tmp == NULL)
          snprintf (timebuf, sizeof (timebuf), _("<corrupt>"));
        else
          snprintf (timebuf, sizeof (timebuf), "%04u-%02u-%02uT%02u:%02u:%02u",

Cheers
  Nick

*** This bug has been marked as a duplicate of bug 17531 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.