|
From: | Nick Clifton |
Subject: | Re: Fix undefined shift overflow |
Date: | Mon, 1 Feb 2016 10:44:16 +0000 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
Hi Michael,
Shifting into and out of the sign bit of an integer is undefined, and this loop unconditionally does both. The below patch should fix it.
Patch approved and applied. Thanks for reporting this. Cheers Nick
[Prev in Thread] | Current Thread | [Next in Thread] |