[Bug binutils/19747] New: compile failure in rl78-dis.c

[spam_hole at shaw dot ca]

https://sourceware.org/bugzilla/show_bug.cgi?id=19747

            Bug ID: 19747
           Summary: compile failure in rl78-dis.c
           Product: binutils
           Version: 2.27 (HEAD)
            Status: NEW
          Severity: normal
          Priority: P2
         Component: binutils
          Assignee: unassigned at sourceware dot org
          Reporter: spam_hole at shaw dot ca
  Target Milestone: ---

I'm getting the following error while compiling binutils for all targets:

rl78-dis.c:232:44: error: use of logical '||' with constant operand
[-Werror,-Wconstant-logical-operand]
                if ((oper->type == RL78_Operand_Indirect ||
RL78_Operand_BitIndirect)
                                                         ^ 
~~~~~~~~~~~~~~~~~~~~~~~~
rl78-dis.c:232:44: note: use '|' for a bitwise operation
                if ((oper->type == RL78_Operand_Indirect ||
RL78_Operand_BitIndirect)
                                                         ^~
                                                         |
1 error generated.

To me, this line in rl78-dis.c looks incorrect. It looks as if it should read

                if ((oper->type == RL78_Operand_Indirect || oper->type ==
RL78_Operand_BitIndirect)

I found this compile error when building trunk revision
efd5b507cc9261b03d547575d9f6453a1425bd59 (Mar 1 2016, 00:00:09).

-- 
You are receiving this mail because:
You are on the CC list for the bug.