[Bug gold/19842] LTO build fails to write call address for weak symbol reference

[ccoutant at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19842

--- Comment #21 from Cary Coutant <ccoutant at gmail dot com> ---
>    /* Skip weak definitions of symbols that are already defined.  */
>    if (newdef && olddef && newweak)
>      { 
> -      *skip = TRUE;
> +      /* Don't skip new non-IR weak syms.  */
> +      if (!((oldbfd->flags & BFD_PLUGIN) != 0
> +           && (abfd->flags & BFD_PLUGIN) == 0))
> +       *skip = TRUE;
>  
>        /* Merge st_other.  If the symbol already has a dynamic index,
>          but visibility says it should not be visible, turn it into a

Hmmm. Unless this was part of an attempt to preserve existing behavior while
moving from a separate hash table to using the new flags, it looks like an
unrelated change that was slipped into this patch without any comment or
justification. I hope Alan can remember what this was about (it's been almost 5
years).

-cary

-- 
You are receiving this mail because:
You are on the CC list for the bug.