[Bug ld/19803] gc-sections breaks PE DLL variable export

[nickc at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=19803

Nick Clifton <nickc at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9104|0                           |1
        is obsolete|                            |
   Attachment #9106|0                           |1
        is obsolete|                            |
   Attachment #9107|0                           |1
        is obsolete|                            |
   Attachment #9115|0                           |1
        is obsolete|                            |

--- Comment #19 from Nick Clifton <nickc at redhat dot com> ---
Created attachment 9121
  --> https://sourceware.org/bugzilla/attachment.cgi?id=9121&action=edit
Revised patch

Hi Martin,

> First, 41f46ed9fea1a066de95b6a85c56393beef0b8b8 (Fix possible failure in 
> the AVR linker tests) introduced (propably accidentically)

Yes, that was a snafu.  

> In my option, this change is not necessary, as it just would hides broken 
> symbols in the export library.

Actually I think that it is needed in order to prevent garbage collected
symbols from leaking into the export table.

> The prefix name patch would need a xstrdup, as name is freed some lines below.

Doh, yes.

> There is second case missing (symbol matching implemented by 
> pe_fixup_stdcalls).

OK - this revised patch contains an attempt to fix this function as well. 
Please could you give it a try and let me know the results.

Cheers
  Nick

-- 
You are receiving this mail because:
You are on the CC list for the bug.