[Bug binutils/25100] New: Compile fails in elf64-ppc.c because of single equal sign instead of double equal for comparison

[p.antoine at catenacyber dot fr]

https://sourceware.org/bugzilla/show_bug.cgi?id=25100

            Bug ID: 25100
           Summary: Compile fails in elf64-ppc.c because of single equal
                    sign instead of double equal for comparison
           Product: binutils
           Version: 2.34 (HEAD)
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: binutils
          Assignee: unassigned at sourceware dot org
          Reporter: p.antoine at catenacyber dot fr
  Target Milestone: ---

Binutils version is commit 6dfc00411292aa3220b33b6ac9553907e3933b0f

Compile scheme is the following :
```
./configure --disable-gdb --enable-targets=all
make MAKEINFO=true && true
```

Environment is 
clang version 10.0.0 (trunk 373424)
Target: x86_64-unknown-linux-gnu

Compile fails with message :
```
elf64-ppc.c:5842:9: error: converting the enum constant to a boolean
[-Werror,-Wint-in-bool-context]
                      && s->root.u.def.section == stub_sec))
```


Patch fixes it :
```
diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c
index 32ed81d9..056d2eea 100644
--- a/bfd/elf64-ppc.c
+++ b/bfd/elf64-ppc.c
@@ -5828,7 +5828,7 @@ sfpr_define (struct bfd_link_info *info,
              if (s == NULL)
                return FALSE;
              if (s->root.type == bfd_link_hash_new
-                 || (s->root.type = bfd_link_hash_defined
+                 || (s->root.type == bfd_link_hash_defined
                      && s->root.u.def.section == stub_sec))
                {
                  s->root.type = bfd_link_hash_defined;
```

-- 
You are receiving this mail because:
You are on the CC list for the bug.