[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Bug gold/23607] gold linker --threads --thread-count,2 causes ld segmen
|
From: |
slyfox at inbox dot ru |
|
Subject: |
[Bug gold/23607] gold linker --threads --thread-count,2 causes ld segmentation fault |
|
Date: |
Tue, 24 Nov 2020 23:50:50 +0000 |
https://sourceware.org/bugzilla/show_bug.cgi?id=23607
Sergei Trofimovich <slyfox at inbox dot ru> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hjl.tools at gmail dot com
--- Comment #8 from Sergei Trofimovich <slyfox at inbox dot ru> ---
binutils from master does not seem to crash on a simple test from #comment7.
Bisected the fix down to
https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=d4820dac5e7608e24fba6d08cde9248b4c4b2928
"""
$ git bisect bad
d4820dac5e7608e24fba6d08cde9248b4c4b2928 is the first bad commit
commit d4820dac5e7608e24fba6d08cde9248b4c4b2928
Author: H.J. Lu <hjl.tools@gmail.com>
Date: Sun Nov 8 04:10:01 2020 -0800
gold: Avoid sharing Plugin_list::iterator
class Plugin_manager has
// A pointer to the current plugin. Used while loading plugins.
Plugin_list::iterator current_;
The same iterator is shared by all threads. It is OK to use it to load
plugins since only one thread loads plugins. Avoid sharing Plugin_list
iterator in all other cases.
PR gold/26200
* plugin.cc (Plugin_manager::claim_file): Don't share Plugin_list
iterator.
(Plugin_manager::all_symbols_read): Likewise.
(Plugin_manager::cleanup): Likewise.
gold/ChangeLog | 8 ++++++++
gold/plugin.cc | 34 +++++++++++++++++-----------------
2 files changed, 25 insertions(+), 17 deletions(-)
"""
Looks related. Dupe of bug #26200?
--
You are receiving this mail because:
You are on the CC list for the bug.