[Bug binutils/28978] [2.36 Regression] O(n²) when parsing DWARF2 info

[nickc at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=28978

Nick Clifton <nickc at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #5 from Nick Clifton <nickc at redhat dot com> ---
(In reply to Steinar H. Gunderson from comment #4)

> I'm not sure if I understand what you mean. From what I can see, the
> reversal is completely, 100% necessary for this patch to do its job. If not,
> you'll have a miss every single time as I understand it.

Oh my brain is so slow!  Yes you are right - the reversal is completely
necessary.  Sorry for the confusion.


> From what I can see, reversing the list takes us from a 0% hit rate to a
> 100% hit rate. I'm not even sure whether lookup_func_by_offset() is needed
> at all anymore (it should really never be called after the patch, if I
> understand correctly), but I don't know all the logic in the function, so I
> left it in for safety.

OK, then lets leave it here for now.  If the issue comes up again in the future
we can look into optimizing the lookup functions.

-- 
You are receiving this mail because:
You are on the CC list for the bug.