[Bug binutils/31722] New: [binutils/readelf] Missing eol in warning string index of <n> converts to an offset of <m> which is too big for section <s>

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=31722

            Bug ID: 31722
           Summary: [binutils/readelf] Missing eol in warning string index
                    of <n> converts to an offset of <m> which is too big
                    for section <s>
           Product: binutils
           Version: 2.43 (HEAD)
            Status: NEW
          Severity: normal
          Priority: P2
         Component: binutils
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

With a proposed gdb test-case and target board fission, I run into:
...
$ readelf -w outputs/gdb.base/check-errno/check-errno-macros > READELF
readelf: Warning: string index of 624 converts to an offset of 0x9c8 which is
too big for section .debug_str.dworeadelf: Warning: string index of 625
converts to an offset of 0x9cc which is too big for section .debug_str.dwo$
...

With this fix:
...
diff --git a/binutils/dwarf.c b/binutils/dwarf.c
index 3ce79f4e5d1..d9131cf473d 100644
--- a/binutils/dwarf.c
+++ b/binutils/dwarf.c
@@ -669,7 +669,7 @@ fetch_indexed_string (uint64_t idx,
       || index_offset + offset_size > index_section->size)
     {
       warn (_("string index of %" PRIu64 " converts to an offset of %#" PRIx64
-             " which is too big for section %s"),
+             " which is too big for section %s\n"),
            idx, index_offset, str_section->name);

       return _("<string index too big>");
...
we get instead:
...
$ readelf -w outputs/gdb.base/check-errno/check-errno-macros > READELF
readelf: Warning: string index of 624 converts to an offset of 0x9c8 which is
too big for section .debug_str.dwo
readelf: Warning: string index of 625 converts to an offset of 0x9cc which is
too big for section .debug_str.dwo
$
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.