[Bug binutils/31940] New: usage text for strings gives '--unicode=show' as a valid option

[aapo.rantalainen at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31940

            Bug ID: 31940
           Summary: usage text for strings gives '--unicode=show' as a
                    valid option
           Product: binutils
           Version: 2.43 (HEAD)
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: binutils
          Assignee: unassigned at sourceware dot org
          Reporter: aapo.rantalainen at gmail dot com
  Target Milestone: ---

binutils/strings -h | grep unicode
        --unicode={default|show|invalid|hex|escape|highlight}
        -U {d|s|i|x|e|h}          Specify how to treat UTF-8 encoded unicode
characters


echo | binutils/strings --unicode=show
        binutils/strings: invalid argument to -U/--unicode: show

echo | binutils/strings -Us
        binutils/strings: invalid argument to -U/--unicode: s



echo | binutils/strings --unicode=locale
        -> no error

echo | binutils/strings -Ul
        -> no error

---
Trivial patch:
diff --git a/binutils/strings.c b/binutils/strings.c
index ec02e1d5fce..5d7be3dd543 100644
--- a/binutils/strings.c
+++ b/binutils/strings.c
@@ -1350,8 +1350,8 @@ usage (FILE *stream, int status)
   -T --target=<BFDNAME>     Specify the binary file format\n\
   -e --encoding={s,S,b,l,B,L} Select character size and endianness:\n\
                             s = 7-bit, S = 8-bit, {b,l} = 16-bit, {B,L} =
32-bit\n\
-  --unicode={default|show|invalid|hex|escape|highlight}\n\
-  -U {d|s|i|x|e|h}          Specify how to treat UTF-8 encoded unicode
characters\n\
+  --unicode={default|locale|invalid|hex|escape|highlight}\n\
+  -U {d|l|i|x|e|h}          Specify how to treat UTF-8 encoded unicode
characters\n\
   -s --output-separator=<string> String used to separate strings in output.\n\
   @<file>                   Read options from <file>\n\
   -h --help                 Display this information\n\

-- 
You are receiving this mail because:
You are on the CC list for the bug.