bug-binutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug binutils/32109] internal error, aborting at bfd/bfd.c:1236 in int _


From: cvs-commit at gcc dot gnu.org
Subject: [Bug binutils/32109] internal error, aborting at bfd/bfd.c:1236 in int _bfd_doprnt
Date: Wed, 16 Oct 2024 12:39:44 +0000

https://sourceware.org/bugzilla/show_bug.cgi?id=32109

--- Comment #8 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Alan Modra <amodra@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=76eab8f47a743bde86be410bce8fd8382eaea6c2

commit 76eab8f47a743bde86be410bce8fd8382eaea6c2
Author: Alan Modra <amodra@gmail.com>
Date:   Sun Oct 13 15:11:59 2024 +1030

    PR32266, segv when linking libclang_rt.asan-powerpc64.so

    Change the mmap support added with commit 9ba56acee518 to always mmap
    memory with PROT_READ | PROT_WRITE.  Prior to that commit most file
    contents were read into a buffer allocated with bfd_alloc or
    bfd_malloc and thus the memory was read/write.  Even after that commit
    any section contents with relocations must be read/write to apply the
    relocs.  Making them all read/write is not a major change, and it
    should not introduce any measurable linker slowdown for contents that
    are not modified.  More importantly, it removes a BFD behaviour
    difference that only triggers when large files are involved.

            PR 32266
            PR 32109
            * libbfd.c (bfd_mmap_local): Remove prot param.  Always mmap
            with PROT_READ | PROT_WRITE.  Adjust all calls.
            (_bfd_mmap_temporary): Rename from _bfd_mmap_readonly_temporary.
            (_bfd_munmap_temporary): Rename from
_bfd_munmap_readonly_temporary.
            _bfd_mmap_persistent): Rename from _bfd_mmap_readonly_persistent.
            (_bfd_generic_get_section_contents): Use PROT_READ | PROT_WRITE
            regardless of relocs.
            * libbfd-in.h: Update decls to suit.  Make non-USE_MMAP variants
            static inline functions.
            * elflink.c: Update all uses of _bfd_mmap functions.
            * elf.c: Likewise.
            (bfd_elf_get_str_section): Revert commit 656f8fbaae.
            * libbfd.h: Regenerate.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]