Re: Bison 3.4.1 released [stable]

[Akim Demaille]

Hi Dennis,

> Le 25 mai 2019 à 16:11, Dennis Clarke <address@hidden> a écrit :
> 
> On 5/25/19 2:38 AM, Akim Demaille wrote:
>> Hi Dennis,
>>> Le 24 mai 2019 à 08:53, Dennis Clarke <address@hidden> a écrit :
>>> 
>>> On 5/22/19 3:34 PM, Akim Demaille wrote:
>>>> The Bison team is sad to announce the crash of Bison 3.4.
>>>> May its cores rest in peace.
>>>> Rejoice!  Bison 3.4 is born again!  And he shall be called Bison 3.4.1.
>>> 
>>> Builds fine on ye ol Solaris 10 sparc boxen and fails every test :
>> Well, not "every", just the ones in examples/.  But because they failed, the 
>> main test suite was skipped.  You can try with make check-local instead of 
>> make check.
> 
> yeah .. that fails too :
> 
> 3.4.1_SunOS5.10_sparc64vii+.001'
> ./tests/testsuite -C tests
> ./tests/testsuite: syntax error at line 53383: `(' unexpected
> gmake: *** [Makefile:8439: check-local] Error 2

The problem is here:

      # Number of found conflicts.
      case $gram in
        (sr)    sr_count=1; rr_count=0;;
        (rr)    sr_count=0; rr_count=1;;
        (sr-rr) sr_count=1; rr_count=1;;
      esac

With old shells, you have to write (no opening parens)

      # Number of found conflicts.
      case $gram in
        sr)    sr_count=1; rr_count=0;;
        rr)    sr_count=0; rr_count=1;;
        sr-rr) sr_count=1; rr_count=1;;
      esac

Which is really silly, and really bad for text editor that try to match parens.

Don't you have bash installed?

I can make the test suite more portable (if we work together), but the simplest 
would really be to use a more modern shell to run the tests.  Something like

make check SHELL=/bin/bash

should work.


> Would be nice if an old XPG4 POSIX type shell would suffice but I know
> that is crazy these days.

:)

Well, the thing is that it's a pain to be compliant with them, if it's useless. 
 If some users do want to use them (and have no alternatives, such as 
installing bash), we can work on it.