[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 3.4.2: test suite is failing
From: |
Akim Demaille |
Subject: |
Re: 3.4.2: test suite is failing |
Date: |
Sat, 21 Sep 2019 14:56:47 +0200 |
Hi Tomasz,
Sorry for the delays.
> Le 17 sept. 2019 à 19:06, Tomasz Kłoczko <address@hidden> a écrit :
>
> 1) in git repo 3.4.2 version is not tagged
Sorry about that, pushed.
> 2) please enable submitting tickets over
What do you mean? Savannah has tickets
(https://savannah.gnu.org/support/?group=bison&func=additem). I don't like
them though, the mailing list is still the preferred approach.
> 3) 3.4.2 test suite is failing (3.4.1 was OK)
Weird, I would expect the problem to have existed in 3.4.1.
> +==48025== 11 bytes in 1 blocks are still reachable in loss record 1 of 2
> +==48025== at 0x483980B: malloc (vg_replace_malloc.c:309)
> +==48025== by 0x1162DC: xmalloc (xmalloc.c:41)
> +==48025== by 0x12082A: UnknownInlinedFun (xalloc.h:218)
> +==48025== by 0x12082A: quotearg_n_options (quotearg.c:918)
> +==48025== by 0x12495D: fixits_run (fixits.c:213)
> +==48025== by 0x10ED8C: main (main.c:243)
I think I see what happens here: I'm freeing the memory allocated by the
quotearg module too soon. Could you please confirm that the following patch
addresses your concern?
Thanks in advance!
diff --git a/src/main.c b/src/main.c
index 3c51eafe..06bcb1c5 100644
--- a/src/main.c
+++ b/src/main.c
@@ -223,7 +223,6 @@ main (int argc, char *argv[])
muscle_free ();
code_scanner_free ();
skel_scanner_free ();
- quotearg_free ();
timevar_pop (tv_free);
if (trace_flag & trace_bitsets)
@@ -249,6 +248,7 @@ main (int argc, char *argv[])
uniqstrs_free ();
complain_free ();
+ quotearg_free ();
return complaint_status ? EXIT_FAILURE : EXIT_SUCCESS;
}