[Bug classpath/25202] javax.security.auth.login.LoginException: no configured modules for

[csm at gnu dot org]

------- Comment #5 from csm at gnu dot org  2006-01-14 21:05 -------
This patch looks pretty good; thanks for doing this!

I do, however have a couple of comments:

  - First, the documentation comments you've added to the Configuration class
look very similar to those Sun distributes. Does the license for Sun's API
documentation allow you to do this?
  - You can feel free to use the `gnu.classpath.SystemProperties' class instead
of the System class to fetch properties like `user.home.' This will avoid
permission checks for those calls.
  - The file is called `ConfigFileParser.java' but the opening comment line
says it's `ConfigurationParser.java.'
  - I think you should consider sending debug statements to a logger, and not
to the console. See the package `gnu.classpath.debug' for more info.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25202