[Bug classpath/25202] javax.security.auth.login.LoginException: no configured modules for

[raif at swiftdsl dot com dot au]

------- Comment #6 from raif at swiftdsl dot com dot au  2006-01-14 21:57 
-------
Subject: Re:  javax.security.auth.login.LoginException: no configured modules
for

On Sunday 15 January 2006 08:05, csm at gnu dot org wrote:
> ------- Comment #5 from csm at gnu dot org  2006-01-14 21:05 -------
> This patch looks pretty good; thanks for doing this!
>
> I do, however have a couple of comments:
>
>   - First, the documentation comments you've added to the
> Configuration class look very similar to those Sun distributes. Does
> the license for Sun's API documentation allow you to do this?

i always thought you can; if not should be easy to remove. Mark?


>   - You can feel free to use the `gnu.classpath.SystemProperties'
> class instead of the System class to fetch properties like
> `user.home.' This will avoid permission checks for those calls.

i thought about that but decided against it for consistency.  the 
rationale is that there is no point bypassing security checks for 
system properties when reading security properties, or files may throw 
one.  ...unless of course all operations do that.

does that make sense?


>   - The file is called `ConfigFileParser.java' but the opening
> comment line says it's `ConfigurationParser.java.'

thanks for picking this up.


>   - I think you should consider sending debug statements to a logger,
> and not to the console. See the package `gnu.classpath.debug' for
> more info.

i tried amending the Component class but didn't see any output when i 
ran the Mauve tests. i's prefer to use proper debugging than the ad-hoc 
approach of sending to System.out.  is there an example usage 
somewhere?


thanks for the comments.  i will wait for other comments on the first 2 
points before re-submitting.


cheers;
rsn


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25202