[bug] BOF condition in keydata.cpp

[teo]

There is a security issue in Keydata::Load, where a fixed length 
buffer is used to copy something from environment.


void Keydata::Load(const char *keypath, const char *environment)
{
        char path[512];
        char seek[33];
        char find[33];
        const char *prefix = NULL;
        char *cp, *ep;
        int fpos;

        if(*keypath == '~')
        {
                prefix = getenv("HOME");
                strcpy(path, prefix);

       // here HOME env var can be poisoned.

also following there are more unchecked strcpy()s


thanks for the cool CommonC++ though :) it helped me to write a 
multithreaded server in a very short time and left me more time
to focus on my exercise.
 

best regards,
    
--
Teodor Cimpoesu

Software Developer, GeCAD Software
http://www.ravantivirus.com