Re: Compiler warnings; minor thread.h patch

[Albert Strasheim]

Hello,

Attached is a patch to fix all the warnings (when compiling with 
-Wall, -ansi and -pedantic) in src, demos, and tests, with the 
exception of an usused variable in one of the demos and the long long 
integer constant warnings in sha.cpp (not quite sure what needs to be 
done here).

I'll feed cc++ to gcc 3.2 and the Intel C++ compiler when I get back to 
work during the second week in January.

Cheers,

Albert

On Sun, 29 Dec 2002, David Sugar wrote:

> I actually fixed a lot of small code issues recently with -Wall on gcc 2.95, 
> so the number of annoying warnings left should already be fairly small and 
> much easier to deal with.
> 
> On Sunday 29 December 2002 08:52, Federico Montesino Pouzols wrote:
> > On Sun, Dec 29, 2002 at 01:15:26PM +0200, Albert Strasheim wrote:
> > > Hello,
> > >
> > > Attached is a patch to remove the extra qualification of getThreadID()
> > > in thread.h on line 1352.
> >
> >     Fixed in CVS.
> >
> > > This warning shows up when compiling Common C++ with the -Wall, -ansi,
> > > and -pedantic flags. I think this should be made the default for the
> > > project?
> >
> >     Yes, it has been suggested by other people on this list and I
> > think it should be done -if is no objection- for the next release. It
> > would require adding a conditional check for gcc -and fixing a lot of
> > seemingly inoffensive warnings that show up when these options are
> > specified.
> >
> > > Another interesting issue that shows up is the extensive use of long
> > > long constants in sha.cpp, which is apparently forbidden by ANSI C++.
> > >
> > > Cheers,
> > >
> > > Albert
> >
> > _______________________________________________
> > Bug-commoncpp mailing list
> > address@hidden
> > http://mail.gnu.org/mailman/listinfo/bug-commoncpp
>

warnfix1.patch
Description: Text document