|
From: | Andrey Kulikov |
Subject: | Fiew bug fixes patch. |
Date: | Wed, 30 Jun 2004 15:02:38 +0400 |
All patchs for version 1.2.1 1. One disagreeable bug: In constructor of ost::Thread parameter class variable "stack" overriten with parameter variable with the same name. As a result can't be created any thread withot any errors or diagnostic. (In my programs i'l always use prefixes "m_" (member) or just "_" for name of the local class variables, and prefix "a_" (argument) for all variables passsed as a parameters to any functions. And it prevents from such very difficult to debug errors) 2. I'l add to win32 config.h one define "CCXX_NO_DLL". If this macro defined, cc++ can be compiled as a static library. In comments in thread.cpp was written: "This project cannot be compiled as a static library. Some implementation stuff require DLL" And if it's "Some implementation stuff" is not necessary, and other functionality still necessary, it is possible to use this macro for compiling cc++ as a static library. (But some changes in projects file is necessary). Other question is what exactly "implementation stuff" require DLL? This information is necessary for prevent unexpectable revelation of fine features. :) In my programs, which intensively useŠ² ost::Thread i not find any difference between DLL and nonDLL linkage. 3. Underground of ost::Mutex in win32. I implement suggestion of David (http://lists.gnu.org/archive/html/bug-commoncpp/2004-06/msg00027.html) and add to win32 config.h two macros: MUTEX_UNDERGROUND_WIN32_MUTEX and MUTEX_UNDERGROUND_WIN32_CRITICALSECTION An one time can be defined only one of this two macros. It's indicate, what must be used for background of ost::Mutex on win32: kernel object "Mutex" or win32 critical section. All changes compiled with VS2003 and tested on WindowsXP. -- Best regards, Andrey mailto:address@hidden
thread.h.patch
Description: Binary data
config.h.patch
Description: Binary data
mutex.cpp.patch
Description: Binary data
thread.cpp.patch
Description: Binary data
[Prev in Thread] | Current Thread | [Next in Thread] |