[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] maint: changing NEWS' copyright date must not invalidate che
From: |
Eric Blake |
Subject: |
Re: [PATCH] maint: changing NEWS' copyright date must not invalidate checksum |
Date: |
Wed, 18 Feb 2009 19:20:08 +0000 (UTC) |
User-agent: |
Loom/3.14 (http://gmane.org/) |
Jim Meyering <jim <at> meyering.net> writes:
>
> Imagine my surprise when the immutable-news part of
> "make syntax-check" failed.
Sorry for not adjusting the hash myself. Filtering out the copyright year is a
good change.
> NEWS_hash = \
> $$(sed -n '/^\*.* $(PREV_VERSION_REGEXP) ([0-9-]*)/,$$p' \
> - $(srcdir)/NEWS | md5sum -)
> + $(srcdir)/NEWS | grep -v '^Copyright .*Free Software' | md5sum -)
Is it worth saving a process here, by folding the grep -v into the sed?
NEWS_hash = \
$$(sed -n 's/^Copyright .*Free Software.*//; \
/^\*.* $(PREV_VERSION_REGEXP) ([0-9-]*)/,$$p' \
$(srcdir)/NEWS | md5sum -)
--
Eric Blake