Re: [PATCH]: cp: make -a option preserve SELinux context and xattrs with reduced diagnostics

[Jim Meyering]

Ondřej Vašík wrote:
> I guess it's time to add the amended cp-a-xattr patch... attached

It is indeed.  Thanks!
I've tweaked NEWS as below and eliminated a space/TAB-only hunk in copy.c.
Other than that, I expect to push it very soon -- as soon as "make
distcheck" completes.


> +++ b/NEWS
> @@ -35,6 +35,9 @@ GNU coreutils NEWS                                    -*- 
> outline -*-
>    at a time.  This was seen to increase throughput.  Up to 2 times
>    when reading cached files on linux for example.
>
> +  cp -a now tries to preserve extended attributes (xattr), doesn't inform
> +  about failure, unlike with --preserve=all

  cp -a now tries to preserve extended attributes (xattr), but does not
  diagnose xattr-preservation failure.  However, cp --preserve=all still does.

...
> diff --git a/src/copy.c b/src/copy.c
> index e37fead..7b4dc08 100644
> --- a/src/copy.c
> +++ b/src/copy.c
> @@ -153,13 +153,13 @@ copy_attr_quote (struct error_context *ctx 
> ATTRIBUTE_UNUSED, char const *str)
>
>  static void
>  copy_attr_free (struct error_context *ctx ATTRIBUTE_UNUSED,
> -             char const *str ATTRIBUTE_UNUSED)
> +                char const *str ATTRIBUTE_UNUSED)