[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] tests: avoid unusual (~1-in-20) failure of a new test
From: |
Jim Meyering |
Subject: |
[PATCH] tests: avoid unusual (~1-in-20) failure of a new test |
Date: |
Fri, 24 Apr 2009 22:00:04 +0200 |
It was not easy to reproduce this one.
>From b726914a4c1ea8f943359d9ad19a09d3ee606694 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Fri, 24 Apr 2009 21:34:59 +0200
Subject: [PATCH] tests: avoid unusual (~1-in-20) failure of a new test
* tests/misc/sort: Remove one of the generated tests.
363 remain in this file alone.
---
tests/misc/sort | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/tests/misc/sort b/tests/misc/sort
index a27f47a..c5a2d74 100755
--- a/tests/misc/sort
+++ b/tests/misc/sort
@@ -369,6 +369,14 @@ foreach my $t (@Tests)
@Tests = triple_test address@hidden;
+# Remember that triple_test creates from each test with exactly one "IN"
+# file two more tests (.p and .r suffix on name) corresponding to reading
+# input from a file and from a pipe. The pipe-reading test would fail
+# due to a race condition about 1 in 20 times.
+# Remove the IN_PIPE version of the "output-is-input" test above.
+# The others aren't susceptible because they have three inputs each.
address@hidden = grep {$_->[0] ne 'output-is-input.p'} @Tests;
+
my $save_temps = $ENV{DEBUG};
my $verbose = $ENV{VERBOSE};
--
1.6.3.rc1.223.g2f326
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [PATCH] tests: avoid unusual (~1-in-20) failure of a new test,
Jim Meyering <=