[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#5958: Sort-8.4 bug
From: |
Pádraig Brady |
Subject: |
bug#5958: Sort-8.4 bug |
Date: |
Tue, 20 Apr 2010 13:08:59 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3 |
On 20/04/10 09:37, Alan Curry wrote:
> A full investigation has revealed:
>
> This bug was introduced between coreutils 7.1 and 7.2, here:
>
>> commit 224a69b56b716f57e3a018af5a9b9379f32da3fc
>> Author: Pádraig Brady <address@hidden>
>> Date: Tue Feb 24 08:37:18 2009 +0000
>>
>> sort: Fix two bugs with determining the end of field
>>
>> * src/sort.c: When no specific number of chars to skip
>> is specified for the end field, always skip the whole field.
>> Also never include leading spaces from next field.
>> * tests/misc/sort: Add 2 new tests for these cases.
>> * NEWS: Mention this bug fix.
>> * THANKS: Add bug reporter.
>> Reported by Davide Canova.
>
> In the diff of that commit, an eword++ was removed from the case 'k' section
> of option parsing, where it did not affect traditional options, and added to
> the limfield() function, where it takes effect regardless of how fields were
> specified.
>
> So it fixed a -k option parsing bug and added a traditional option parsing
> bug.
Sigh. I didn't fully understand/consider the obsolete syntax when doing that.
I'll look at you patch tonight and push it in.
cheers,
Pádraig.