[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#9780: sort -u throws out non-duplicates
From: |
Paul Eggert |
Subject: |
bug#9780: sort -u throws out non-duplicates |
Date: |
Fri, 17 Aug 2012 12:19:35 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:14.0) Gecko/20120714 Thunderbird/14.0 |
On 08/16/2012 02:03 PM, Jim Meyering wrote:
> * src/sort.c (saved_line): New static/global, renamed and moved from...
> (write_unique): ...here.
I see a couple of problems with this patch. Pedantically,
the behavior of 'overlap' is undefined on hosts that
use a segmented architecture, because '<=' is not reliable
on pointers into different buffers. (I have the vague recollection
that some compilers even rely on this to generate faster code
on flat architectures....) More importantly, suppose the
buffer is reallocated (because it grows)? Won't 'overlap'
do the wrong thing after that? And it'd be nice if we didn't
have to worry about making a copy of that line.
I'll see if I can come up with something that addresses these
objectinos.
- bug#9780: sort -u throws out non-duplicates, (continued)
- bug#9780: sort -u throws out non-duplicates, Jim Meyering, 2012/08/14
- bug#9780: sort -u throws out non-duplicates, Jim Meyering, 2012/08/15
- bug#9780: sort -u throws out non-duplicates, Jim Meyering, 2012/08/16
- bug#9780: sort -u throws out non-duplicates, Jim Meyering, 2012/08/16
- bug#9780: sort -u throws out non-duplicates, Bernhard Voelker, 2012/08/16
- bug#9780: sort -u throws out non-duplicates, Jim Meyering, 2012/08/16
- bug#9780: sort -u throws out non-duplicates, Jim Meyering, 2012/08/16
- bug#9780: sort -u data loss deserves new release ASAP [Re: bug#9780: sort -u..., Jim Meyering, 2012/08/17
- bug#9780: sort -u data loss deserves new release ASAP [Re: bug#9780: sort -u..., Bernhard Voelker, 2012/08/17
- bug#9780: sort -u data loss deserves new release ASAP [Re: bug#9780: sort -u..., Jim Meyering, 2012/08/17
- bug#9780: sort -u throws out non-duplicates,
Paul Eggert <=
- bug#9780: sort -u throws out non-duplicates, Jim Meyering, 2012/08/17
- bug#9780: sort -u throws out non-duplicates, Paul Eggert, 2012/08/17
- bug#9780: sort -u throws out non-duplicates, Jim Meyering, 2012/08/17
- bug#9780: sort -u throws out non-duplicates, Paul Eggert, 2012/08/17
- bug#9780: sort -u throws out non-duplicates, Jim Meyering, 2012/08/17
- bug#9780: sort -u throws out non-duplicates, Paul Eggert, 2012/08/17
- bug#9780: sort -u throws out non-duplicates, Jim Meyering, 2012/08/20
- bug#9780: sort -u throws out non-duplicates, Paul Eggert, 2012/08/17
- bug#9780: sort -u throws out non-duplicates, Jim Meyering, 2012/08/17
- bug#9780: sort -u throws out non-duplicates, Jim Meyering, 2012/08/18