[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#12225: One test failed on Solaris 10
From: |
Jim Meyering |
Subject: |
bug#12225: One test failed on Solaris 10 |
Date: |
Sun, 19 Aug 2012 22:33:01 +0200 |
Jim Meyering wrote:
> Paul Eggert wrote:
>> I've reproduced that one test failing, and propose the
>> following patch. Thanks for reporting it.
>>
>> Subject: [PATCH] tests: port df/no-mtab-status to Solaris
>>
>> * tests/df/no-mtab-status: Include <mntent.h> in test program, so
>> that the getmntent hack compilation fails on Solaris, as it
>> should, since it's not compatible with Solaris. Reported by
>> Stefano Lattarini in <http://bugs.gnu.org/12225>.
>> ---
>> tests/df/no-mtab-status | 3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/tests/df/no-mtab-status b/tests/df/no-mtab-status
>> index 6e07854..e434f5f 100755
>> --- a/tests/df/no-mtab-status
>> +++ b/tests/df/no-mtab-status
>> @@ -26,6 +26,7 @@ df || skip_ "df fails"
>> cat > k.c <<'EOF' || framework_failure_
>> #include <stdio.h>
>> #include <errno.h>
>> +#include <mntent.h>
>>
>> struct mntent *getmntent (FILE *fp)
>> {
>> @@ -44,7 +45,7 @@ EOF
>>
>> # Then compile/link it:
>> $CC -shared -fPIC -ldl -O2 k.c -o k.so \
>> - || framework_failure_ 'failed to compile with -shared -fPIC'
>> + || skip_ "getmntent hack does not work on this platform"
>
> Thanks Stefano and Paul.
> That looks good for 8.19. Please push.
FYI, I've just pushed this. no problem.