|
| From: | Paul Eggert |
| Subject: | bug#35291: [PATCH] split: fix incorrect suffix length computation |
| Date: | Sat, 8 Jun 2019 12:36:16 -0700 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
Johannes Altmanninger wrote:
Does anyone have time to review this? I think it's an evident bug. I can try to improve the clarity of the patch if needed.
It's not clarity that needs fixing, it's also correctness. A quick look suggests that the proposed fix can go into an infinite loop due to unsigned integer overflow. This is why the current code uses division and not multiplication.
| [Prev in Thread] | Current Thread | [Next in Thread] |