bug#36831: enhance 'directory not empty' message

[Paul Eggert]

Thanks, that's better, but we're still missing some opportunities for 
improvement.

>     mv: cannot move 'A' to 'B/A': Target directory not empty

This should be "Destination" not "Target". (A target directory is something 
different; this is merely a destination directory.) Similar changes need to be 
made uniformly throughout the patch.


> +** Improvements
> +
> +  rm now prints clearer error messages when a failure relates to the

You meant "mv" not "rm".

Come to think of it, the same improvement should be made to ln, cp, install and 
shred. Basically, to any program that uses 'rename' or 'link' or similar 
syscalls, and which reports an error if the syscall fails.

> +static char*

Space before "*".

> +strerror_target (int e)

Change name to "strerror_dest" or something like that, to be consistent with the 
terminology "destination" rather than "target".

This function should return NULL instead of aborting when the errno value is 
inapplicable. That way, its callers need not hardcode which errno values it handles.