[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Eliminate the static variable
|
From: |
Derek Robert Price |
|
Subject: |
Re: [PATCH] Eliminate the static variable |
|
Date: |
Mon, 24 Sep 2001 11:17:36 -0400 |
Alexey Mahotkin wrote:
> I was looking at the Find_Names() function and noticed that we could
> get rid of "static filelist" variable, using the standard 'closure'
> mechanism. Here is the patch:
>
> 2001-09-23 Alexey Mahotkin <alexm@hsys.msk.ru>
>
> * find_names.c (Find_Names): Use 'closure' feature of walklist()
> to eliminate the static variable.
Committed with minor changes, but your ChangeLog entry didn't list all the
functions you'd changed:
2001-09-24 Derek Price <dprice@collab.net>
* find_names.c (add_entries_proc): Leave closure specified as such in
the
function definition for clarity.
* find_names.c (Find_Names): Use 'closure' feature of walklist()
to eliminate the static variable.
(add_entries_proc): Expect closure to be the file list.
(Patch from Alexey Mahotkin <alexm@hsys.msk.ru>.)