[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: cvs 1.11.2 buffer.c blocking socket/pipe w/bugfix
From: |
Larry Jones |
Subject: |
Re: cvs 1.11.2 buffer.c blocking socket/pipe w/bugfix |
Date: |
Wed, 25 Sep 2002 12:54:07 -0400 (EDT) |
Derek Robert Price writes:
>
> Hmm. You're right. All the getc() call really seems to be checking for
> is EOF - I was thinking the attempt to get a character was important for
> some reason. Anyhow, I'm running a make check on it now. If it's
> successful and there are no objections raised, I'll check it in.
I assume you're checking:
> Mark D. Baushke wrote:
>
> >Hmmm.. I have not tested it, but I suppose !feof(bc->fp) might work on
> >some platforms.
If so, it most definitely is *not* equivalent and does not work on any
platform. feof() doesn't return true unless some actual I/O routine has
already encountered EOF, which won't ever have happened in normal
operation. The call to getc() is an actual I/O that tests for EOF now.
-Larry Jones
Nothing spoils fun like finding out it builds character. -- Calvin