Re: [PATCH] tiny initialization refactoring in diff.c

[Derek Robert Price]

Alexey Mahotkin wrote:

> > > > > > "DRP" == Derek Robert Price <derek@ximbiot.com> writes:
> > > > > >            
>
> >> I do not think that NULL-initializing deserves two lines of comments.
> >> 
>
> DRP> You might be right, but you'll need to submit this to the difflib
> DRP> project to get it accepted.  I don't like maintaining unecessary
> DRP> diffs to imported code.  It just makes for more problems on import of
> DRP> new vendor releases.
>
> Derek,
>
> there is a misunderstanding.  That patch is against src/diff.c, not
> diff/diff.c.  It's CVS' own code.
>
>
> DRP> In short, I'm rejecting this patch.  Sorry & thanks for trying.
>
> "You Tried To Trick Me" (tm)
>
> Please apply :) 
>  

Whoops.  You're right.  Sorry about that.

In any case, you'd made a convert of me and when I was working on the 
diff fix recently suggested by Paul Edwards, I cam across what I thought 
was a different case of the initializations with two lines of comments 
and tidied exactly as you did in this patch, so it's already on stable 
and should be checked into feature as soon as my `make check' finishes 
running on my merged workspace.

Thanks and sorry about that.  I'll try not to do it again.  :)

Derek

--
               *8^)

Email: derek@ximbiot.com

Get CVS support at <http://ximbiot.com>!
--
Pi R squared?!?! Nooo! Pie R round, cornbread R square!