bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Is there really any interest in a patch to allow cvs 1.11.6


From: Paul Edwards
Subject: Re: Is there really any interest in a patch to allow cvs 1.11.6
Date: Tue, 07 Oct 2003 21:05:47 GMT

"Larry Jones" <lawrence.jones@eds.com> wrote in message 
news:mailman.1248.1065539348.21628.bug-cvs@gnu.org...
> Paul Edwards writes:
> >
> > What is EXIT_FAILURE defined as in your stdlib.h?
> > -1 or 255?
> >
> > Whatever it is, the fact that it isn't 1 is what is stuffing up
> > the script.
>
> It shouldn't be -- the diff code explicitly returns 0 (no differences),
> 1 (some differences), or 2 (something went wrong), it does not use

Correct, diff does return that.

> EXIT_FAILURE (at least not intentionally).

And then in main.c, the:

err = (*cm->func()) (argc, argv);

will have err = 0, 1 or 2.

and then the call to exit() will convert 1 or 2 into EXIT_FAILURE.

> sanity.sh is legitimately
> checking for the correct exit status, so it's the exit status that's
> wrong, not the sanity.sh script.

sanity.sh doesn't have any tests for a return code of 2, otherwise
it would fail, because of the above, I believe.

BFN.  Paul.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]