Re: patch: new 'cvs import -X' option.

[Mark D. Baushke]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Chris,

I do not have any fundamental objections to your
proposed feature. In fact, I can see how it would
be very useful to have available.

I will note that your change to src/import.c
includes the use of C99/C++ style comments (that
begin with //) which is not permitted in our
current C89 compliant source base.

...
// XXXCGD ADD COMMENT
...
// XXXCGD FIX COMMENTS
...

I suppose those should be removed from the final patch...

It would probably be useful to add a paragraph to
the documentation about how a user would move the
code from the vendor branch to the main trunk

     cvs import -X module vendor vendor-release-new
     ...in another checked out tree using either

            cvs update -jvendor-release-new
     ...or
            cvs update -jvendor-release-old -jvendor-release-new

All that aside, what do other folks think of this patch?
(btw: it does apply cleanly to the top-of-tree feature branch.)

        -- Mark
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (FreeBSD)

iD8DBQFA2Mpr3x41pRYZE/gRAvh7AJ9O6vXnFcFXL5hu8i8N+dMGBwgyOQCfXqJk
5uHLDdE1DgTKhm0K9UiaDng=
=DxJM
-----END PGP SIGNATURE-----