[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Winsock or Winsock2 - Single Point Of Change
From: |
Derek Price |
Subject: |
Re: Winsock or Winsock2 - Single Point Of Change |
Date: |
Sun, 25 Sep 2005 19:44:04 -0400 |
User-agent: |
Mozilla Thunderbird 1.0.6 (Windows/20050716) |
Conrad T. Pino wrote:
>This patch changes all <winsock.h> to <sys/socket.h> which includes
><winsock2.h> and "gethostname" prototype in "windows-NT/unistd.h"
>is modified to match <winsock2.h> prototype.
>
>IMO all <winsock.h> should be replaced with <sys/socket.h> which
>will include the appropriate Windows header file.
>
>
This patch looks good, except I think you should carry through and
simplify - remove all the #ifdef WINSOCK_H #else stuff, adding an empty
windows-NT/netinet/in.h, if necessary.
>I suggest moving to Winsock2 but IMO that is optional.
>
>
Sure. Whatever you think is best.
Regards,
Derek
--
Derek R. Price
CVS Solutions Architect
Ximbiot <http://ximbiot.com>
v: +1 717.579.6168
f: +1 717.234.3125
<mailto:derek@ximbiot.com>