[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[patch #4678] Fix for segfaults/loops on AIX due to dead clients
From: |
anonymous |
Subject: |
[patch #4678] Fix for segfaults/loops on AIX due to dead clients |
Date: |
Tue, 6 Dec 2005 14:27:54 +0000 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 Firefox/1.5 |
URL:
<http://savannah.nongnu.org/patch/?func=detailitem&item_id=4678>
Summary: Fix for segfaults/loops on AIX due to dead clients
Project: Concurrent Versions System
Submitted by: None
Submitted on: Tue 12/06/05 at 14:27
Category: None
Priority: 5 - Normal
Status: None
Privacy: Public
Assigned to: None
Originator Email: allan.bazinet@gmail.com
Open/Closed: Open
Fixed Release: None
Fixed Feature Release: None
_______________________________________________________
Details:
This patch corrects two problems observed in the 1.11.21 release of CVS on
AIX systems. The routine affected is stdio_buffer_shutdown() in
src/buffer.c. Two issues are corrected.
Firstly, the assertion if fstat() fails is removed -- on an AIX system,
fstat() will return -1 if the client has gone away unexpectedly. This being
an unfortunately common use case, an assertion for this state is
undesirable.
Secondly, this routine contained calls to error() using 1 as the first
parameter, which instructs the server to shut down. However, this routine is
active because the server is shutting down, and thus the 1 parameter causes an
infinite recursion. These calls have been changed to use 0 as the first
parameter.
_______________________________________________________
Carbon-Copy List:
CC Address | Comment
------------------------------------+-----------------------------
allan --DOT-- bazinet --AT-- gmail --DOT-- com | Originator Email
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Tue 12/06/05 at 14:27 Name: buffer.c.patch Size: 4.32KB By: None
Context diff for src/buffer.c
<http://savannah.nongnu.org/patch/download.php?item_id=4678&item_file_id=5554>
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/patch/?func=detailitem&item_id=4678>
_______________________________________________
Message sent via/by Savannah
http://savannah.nongnu.org/
- [patch #4678] Fix for segfaults/loops on AIX due to dead clients,
anonymous <=