Re: Modifications to sanity.sh to support MSVC binary

[Derek R. Price]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jim Hyslop wrote:

> $msvc_binary will only be set to true if the user passes a new
> command-line argument, and if `uname | grep CYGWIN` returns true.

Why would you need both of these checks?  Or would the script abort out
of politeness if it got the option to use Windows paths and it wasn't
running under Cygwin?

> Most of the usage of this will be converting
> '${CVSROOT_DIRNAME}/somepath' to '`posix_to_hostpath_regex
> ${CVSROOT_DIRNAME}/somepath'. As an example, ere is the modified
> basica-0b test:
> 
>         mkdir 1; cd 1
>         dotest basica-0a "$testcvs -q co -l ."
>         mkdir first-dir
>         dotest basica-0b "$testcvs add first-dir" \
> "Directory `posix_to_hostpath_regex ${CVSROOT_DIRNAME}`/first-dir added
> to the repository"

This looks good, except if you are only going to convert the
$CVSROOT_DIRNAME portion of the path, I might suggest that only doing it
once, like:

        CVSROOT_DIRRE=`posix_to_hostpath_regex $CVSROOT_DIRNAME`

and then replacing uses of $CVSROOT_DIRNAME with $CVSROOT_DIRRE in the
dotest calls might be more succinct.


Sorry for taking so long to getting around to checking on the bug-cvs
traffic.

Regards,

Derek
- --
Derek R. Price
CVS Solutions Architect
Get CVS support at Ximbiot <http://ximbiot.com>!
v: +1 248.835.1260
f: +1 248.835.1263
<mailto:derek@ximbiot.com>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEoWvGLD1OTBfyMaQRAlvmAJ42XPBiBq+QSn+166BbLzNdQEHlwACghqPY
NDoZv+LaUv1drF7uYT1uOSQ=
=LDN6
-----END PGP SIGNATURE-----