Re: 1.11.22 and MSVC

[Sergei Antonov]

On 7/23/06, Mark D. Baushke <mdb@gnu.org> wrote:

> > BUG #1
> > line
> >     free (cvs_password);
> > in src/login.c
> > and line
> >  free (password);
> > in src/client.c
> >
> > both free the same buffer, so, when the "login" command is being executed,
> > "free (cvs_password);" tries to free an already freed pointer. Debug runtime
> > checks in MSVC catch this.
>
> Hmmm... on the other hand, there are other code paths that need the
> password returned by get_cvs_password to be freed. See the patch below.
> I don't have time to test this right now, so if you could rerun your
> test to see if it works, that would be great.

Your patch fixes the problem. Thank you.

> > BUG #3
> > All .dsw and .dsp files must have \r\n line ends instead of \n line ends.
> > Without that Visual Studio doesn't open them.
>
> They probably started life this way and had the line endings changed by
> checkout from a UNIX box because the files are not -kb in nature. If you
> checkout a copy of the cvs1-11-x-branch directly, I suspect things
> should work.

I forgot to write that had got my sources from cvs-1.11.22.tar.bz2.
.dsp/.dsw files there have UNIX line endings, so MSVC doesn't open them :(.