[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 2 issues with binning
From: |
Tim Rice |
Subject: |
Re: 2 issues with binning |
Date: |
Wed, 22 Jun 2022 22:14:01 +0000 |
Hey all,
Thanks for the good analysis, as usual, Erik :)
Please check the Git commit 42da191 which I just sent up. Hopefully it
correctly implements what Erik summarized, and ticks the right documentation
boxes.
Regarding the floating point issue, it became easy to see the source of the
problem when I added some printf statements. As you suspected, 4.2/0.1 ends up
looking like 41.999 plus change, so the result gets gated into the 4.1 bin.
This brought to mind our discussion last month about incorporating arbitrary
precision into GNU Datamash. Whereas it would be difficult to remediate such
issues in time for v1.8, the plan to make AP available in v2.0 will hopefully
do the job for us.
I've made a note to include "4.2 | bin:0.1" as one of our tests for AP.
~ Tim