Re: Thanks for the update (Was: datamash: "antimode"...)

[Erik Auerswald]

On Thu, Dec 07, 2023 at 02:00:45PM -0800, Kingsley G. Morse Jr. wrote:
> 
> Thanks for updating me on your progress with what
> seems to me to be a complex and important task.

You're welcome.

> [...]
> On 12/07/2023 20:21, Erik Auerswald wrote:
> > On Tue, Dec 05, 2023 at 12:39:44PM +0100, Erik Auerswald wrote:
> > > On Mon, Dec 04, 2023 at 09:05:57PM -0800, Kingsley G. Morse Jr. wrote:
> > > > [...]
> > > > The main reason I'm writing is datamash's
> > > > "antimode" statistical grouping operation did not
> > > > work as I expected.
> > > > [...]
> > > For me, this also looks like a bug.  I think that the code is wrong and
> > > the man page describes the intended behavior.
> > 
> > I have just added tests for both the "mode" and "antimode" operations to
> > the datamash development version in git.  Both operations are implemented
> > in the same function src/utils.c::mode_value().  The "mode" code path looks
> > OK to me, but the "antimode" code path seems wrong.
> > 
> > Some of the "antimode" tests fail and are commented out, including the test
> > case from your bug report.
> > 
> > > I hope that I'll have time to look into this in about two weeks.
> > 
> > I have not yet found a fix for the bug, but should have more free time in
> > two weeks.

I have just pushed a fix for this issue to the datamash development repository:
https://git.savannah.gnu.org/gitweb/?p=datamash.git;a=commitdiff;h=a4b48a8ac04ea9813fb83952e51ed87af44cbf6a

Kind regards,
Erik