[Bug-ddrescue] Re: [PATCH] ascii "vissualization"

[Michael Niedermayer]

Hi

On Tue, Aug 15, 2006 at 08:03:12PM +0200, Antonio Diaz Diaz wrote:
> Hello Michael.
> 
> Michael Niedermayer wrote:
> >attached you will find a patch which adds some ascii vissualization of the
> >ddrescuing, if your terminal supports it should be colorized too
> 
> Thanks for your contribution, but I agree with Ariel that doing fancy 
> things with the terminal will cause portability problems. I have 
> experienced such problems with GNU Moe, but Moe is an editor, and it 
> must do fancy things with the terminal. However , the main job of 
> ddrescue is data rescue, and I don't like the idea of creating stability 
> or portability problems "just" to see some graphics on screen. GNU 
> Ddrescue is not only used on GNU/Linux systems.

well, my patch adds just standard c(++) code without any external 
dependancies and its disabled by default so it cannot add any
portability or stability problems ignoring compiler bugs and ignoring
int64_t which if you like i can replace by long long though that is
AFAIK not part of the c++ standard either, both int64_t and long
long are in C99 and my feeling would suggest that int64_t has been
part of the c standard for longer ...

if you want i can also make the ansi color sequences optional though
i hoped that terminals which dont support them would simply ignore them

without the ANSI color codes my code does nothing which ddrescue didnt
already, the escape code to move the cursor up was already there and
hardcoded

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is