Re: [Bug-ddrescue] [PATCH 5/5] mapfile: Add several missing fclose calls

bug-ddrescue

From:	Antonio Diaz Diaz
Subject:	Re: [Bug-ddrescue] [PATCH 5/5] mapfile: Add several missing fclose calls
Date:	Mon, 05 Aug 2019 18:54:23 +0200
User-agent:	Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.9.1.19) Gecko/20110420 SeaMonkey/2.0.14

Rosen Penev wrote:

Found with clang-analyzer.

There is no need to close the mapfile just before exiting with errorstatus. It is open for reading and will be closed on exit anyway.

Current Thread

[Next in Thread]

[Bug-ddrescue] [PATCH 3/5] io: Add missing prototype, (continued)
- [Bug-ddrescue] [PATCH 3/5] io: Add missing prototype, Rosen Penev, 2019/08/02
  - Re: [Bug-ddrescue] [PATCH 3/5] io: Add missing prototype, Antonio Diaz Diaz, 2019/08/05
    - Re: [Bug-ddrescue] [PATCH 3/5] io: Add missing prototype, Rosen Penev, 2019/08/05
    - Re: [Bug-ddrescue] [PATCH 3/5] io: Add missing prototype, Antonio Diaz Diaz, 2019/08/05
    - Re: [Bug-ddrescue] [PATCH 3/5] io: Add missing prototype, Rosen Penev, 2019/08/05
    - Re: [Bug-ddrescue] [PATCH 3/5] io: Add missing prototype, Antonio Diaz Diaz, 2019/08/05
- [Bug-ddrescue] [PATCH 2/5] treewide: Replace old style cast with static_cast, Rosen Penev, 2019/08/02
- [Bug-ddrescue] [PATCH 4/5] command_mode: Add missing cctype header, Rosen Penev, 2019/08/02
  - Re: [Bug-ddrescue] [PATCH 4/5] command_mode: Add missing cctype header, Antonio Diaz Diaz, 2019/08/05
- [Bug-ddrescue] [PATCH 5/5] mapfile: Add several missing fclose calls, Rosen Penev, 2019/08/02
  - Re: [Bug-ddrescue] [PATCH 5/5] mapfile: Add several missing fclose calls, Antonio Diaz Diaz <=
- Re: [Bug-ddrescue] [PATCH 1/5] treewide: Replace 0 with NULL where appropriate, Antonio Diaz Diaz, 2019/08/05
  - Re: [Bug-ddrescue] [PATCH 1/5] treewide: Replace 0 with NULL where appropriate, Rosen Penev, 2019/08/05