Re: [Bug-ddrescue] [PATCH 7/7] [clang-tidy] Sort includes according to L

bug-ddrescue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-ddrescue] [PATCH 7/7] [clang-tidy] Sort includes according to L

From:	Antonio Diaz Diaz
Subject:	Re: [Bug-ddrescue] [PATCH 7/7] [clang-tidy] Sort includes according to LLVM rules
Date:	Wed, 16 Oct 2019 19:34:53 +0200
User-agent:	Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.9.1.19) Gecko/20110420 SeaMonkey/2.0.14

Rosen Penev wrote:

Found with llvm-include-order

Rules are, C++ headers, then C, then private.

Found what? Ddrescue already includes headers in the above order. The onlything this patch seems to do is to add a blank line between C++ and Cheaders and randomly reorder some headers inside each group. Nothing useful,much less a bug.

[Prev in Thread]

Current Thread

[Next in Thread]

[Bug-ddrescue] [PATCH 4/7] [clang-tidy] Access statmic member through qualified-id, (continued)
- [Bug-ddrescue] [PATCH 4/7] [clang-tidy] Access statmic member through qualified-id, Rosen Penev, 2019/10/14
  - Re: [Bug-ddrescue] [PATCH 4/7] [clang-tidy] Access statmic member through qualified-id, Antonio Diaz Diaz, 2019/10/16
- [Bug-ddrescue] [PATCH 6/7] [clang-tidy] Use O_CLOEXEC when opening files, Rosen Penev, 2019/10/14
  - Re: [Bug-ddrescue] [PATCH 6/7] [clang-tidy] Use O_CLOEXEC when opening files, Antonio Diaz Diaz, 2019/10/16
    - Re: [Bug-ddrescue] [PATCH 6/7] [clang-tidy] Use O_CLOEXEC when opening files, Rosen Penev, 2019/10/16
- [Bug-ddrescue] [PATCH 5/7] [clang-tidy] Don't use else after a return statement, Rosen Penev, 2019/10/14
  - Re: [Bug-ddrescue] [PATCH 5/7] [clang-tidy] Don't use else after a return statement, Antonio Diaz Diaz, 2019/10/15
    - Re: [Bug-ddrescue] [PATCH 5/7] [clang-tidy] Don't use else after a return statement, Paul Daniels, 2019/10/15
    - Re: [Bug-ddrescue] [PATCH 5/7] [clang-tidy] Don't use else after a return statement, Rosen Penev, 2019/10/16
- [Bug-ddrescue] [PATCH 7/7] [clang-tidy] Sort includes according to LLVM rules, Rosen Penev, 2019/10/14
  - Re: [Bug-ddrescue] [PATCH 7/7] [clang-tidy] Sort includes according to LLVM rules, Antonio Diaz Diaz <=
- [Bug-ddrescue] [PATCH 2/7] treewide: Replace size() with empty() where appropriate, Rosen Penev, 2019/10/14
  - Re: [Bug-ddrescue] [PATCH 2/7] treewide: Replace size() with empty() where appropriate, Antonio Diaz Diaz, 2019/10/16
    - Re: [Bug-ddrescue] [PATCH 2/7] treewide: Replace size() with empty() where appropriate, Rosen Penev, 2019/10/16
    - Re: [Bug-ddrescue] [PATCH 2/7] treewide: Replace size() with empty() where appropriate, Antonio Diaz Diaz, 2019/10/16
- [Bug-ddrescue] [PATCH 3/7] [clang-tidy] Remove const from superfluous locations, Rosen Penev, 2019/10/14
  - Re: [Bug-ddrescue] [PATCH 3/7] [clang-tidy] Remove const from superfluous locations, Antonio Diaz Diaz, 2019/10/16
- Re: [Bug-ddrescue] [PATCH 1/7] tree: Remove stdint.h from two unnecessary places, Antonio Diaz Diaz, 2019/10/15

Prev by Date: Re: [Bug-ddrescue] [PATCH 6/7] [clang-tidy] Use O_CLOEXEC when opening files
Next by Date: Re: [Bug-ddrescue] [PATCH 2/7] treewide: Replace size() with empty() where appropriate
Previous by thread: [Bug-ddrescue] [PATCH 7/7] [clang-tidy] Sort includes according to LLVM rules
Next by thread: [Bug-ddrescue] [PATCH 2/7] treewide: Replace size() with empty() where appropriate
Index(es):
- Date
- Thread