[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bugs #11005] import-gnulib.sh use of 'test -e "$1"/gnulib-tool' is not
From: |
James Youngman |
Subject: |
[bugs #11005] import-gnulib.sh use of 'test -e "$1"/gnulib-tool' is not portable |
Date: |
Mon, 15 Nov 2004 05:06:00 -0500 |
User-agent: |
Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0; Logica 5.5 SP2; .NET CLR 1.1.4322) |
This mail is an automated notification from the bugs tracker
of the project: findutils.
/**************************************************************************/
[bugs #11005] Latest Modifications:
Changes by:
James Youngman <address@hidden>
'Date:
Mon 11/15/2004 at 09:55 (GMT)
What | Removed | Added
---------------------------------------------------------------------------
Assigned to | None | jay
Release | None | 4.2.4
------------------ Additional Follow-up Comments ----------------------------
As for the automake problem, this is already logged as
bug #10972.
As far as "test -e" goes, perhaps I should put a note in somewhere that you
should be using a POSIX-compliant shell. POSIX (IEEE Std 1003.1, 2003)
requires that "test -e" be supported. See for example
http://www.opengroup.org/onlinepubs/009695399/utilities/test.html
However, the change you suggest is obviously simple and the right thing to do,
so I'll just fix that in CVS (plus the bug where we exit import-gnulib with
return value 0 without having done anything).
/**************************************************************************/
[bugs #11005] Full Item Snapshot:
URL: <http://savannah.gnu.org/bugs/?func=detailitem&item_id=11005>
Project: findutils
Submitted by: Mark D Baushke
On: Mon 11/15/2004 at 08:12
Category: None
Severity: 5 - Average
Item Group: None
Resolution: None
Privacy: Public
Assigned to: jay
Originator Name:
Originator Email:
Status: Open
Release: 4.2.4
Fixed Release: 4.2.0
Summary: import-gnulib.sh use of 'test -e "$1"/gnulib-tool' is not portable
Original Submission: 'test' is typically built-in to the shell and many shells
do NOT consider 'test -e' to be recognized.
Example: Solaris 9
/bin/sh
$ test -e /tmp/mdbwork/gnulib/gnulib-tool
test: argument expected
bash-2.05$ test -e /tmp/mdbwork/gnulib/gnulib-tool
bash-2.05$ echo $?
0
bash-2.05$
I recommend you replace the 'test -e' with a 'test -f'
in this case.
Even after making this change, there are still a few
problems with following the README-CVS rules in the
cvs version of findutils...
aclocal -I m4 -I gnulib/m4
/usr/local/bin/m4: LIBOBJS_NORMALIZE: No such file or directory
configure.in:138: warning: jm_AC_TYPE_LONG_LONG is m4_require'd but is not
m4_defun'd
configure.in:138: jm_AC_TYPE_LONG_LONG is required by...
configure.in:136: jy_AC_TYPE_INTMAX_T is expanded from...
configure.in:138: the top level
bash-2.05$ autoheader
configure.in:138: warning: jm_AC_TYPE_LONG_LONG is m4_require'd but is not
m4_defun'd
configure.in:138: jm_AC_TYPE_LONG_LONG is required by...
configure.in:136: jy_AC_TYPE_INTMAX_T is expanded from...
configure.in:138: the top level
bash-2.05$ autoconf
configure.in:138: warning: jm_AC_TYPE_LONG_LONG is m4_require'd but is not
m4_defun'd
configure.in:138: jm_AC_TYPE_LONG_LONG is required by...
configure.in:136: jy_AC_TYPE_INTMAX_T is expanded from...
configure.in:138: the top level
configure.in:125: error: possibly undefined macro: jm_AC_TYPE_LONG_LONG
If this token and others are legitimate, please use m4_pattern_allow.
See the Autoconf documentation.
bash-2.05$
bash-2.05$ automake --add-missing --copy
configure.in:138: warning: jm_AC_TYPE_LONG_LONG is m4_require'd but is not
m4_defun'd
configure.in:138: jm_AC_TYPE_LONG_LONG is required by...
configure.in:136: jy_AC_TYPE_INTMAX_T is expanded from...
configure.in:138: the top level
doc/Makefile.am:1: installing `doc/mdate-sh'
configure.in:4: installing `./config.guess'
configure.in:4: installing `./config.sub'
bash-2.05$
bash-2.05$ automake --version
automake (GNU automake) 1.9.3
Written by Tom Tromey <address@hidden>.
Copyright 2004 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
bash-2.05$ autoconf --version
autoconf (GNU Autoconf) 2.59
Written by David J. MacKenzie and Akim Demaille.
Copyright (C) 2003 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
bash-2.05$ aclocal --version
aclocal (GNU automake) 1.9.3
Written by Tom Tromey <address@hidden>
Copyright (C) 2004 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
bash-2.05$
Follow-up Comments
------------------
-------------------------------------------------------
Date: Mon 11/15/2004 at 09:55 By: James Youngman <jay>
As for the automake problem, this is already logged as
bug #10972.
As far as "test -e" goes, perhaps I should put a note in somewhere that you
should be using a POSIX-compliant shell. POSIX (IEEE Std 1003.1, 2003)
requires that "test -e" be supported. See for example
http://www.opengroup.org/onlinepubs/009695399/utilities/test.html
However, the change you suggest is obviously simple and the right thing to do,
so I'll just fix that in CVS (plus the bug where we exit import-gnulib with
return value 0 without having done anything).
For detailed info, follow this link:
<http://savannah.gnu.org/bugs/?func=detailitem&item_id=11005>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/