bug-findutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #45930] -ignore_readdir_race ineffective in find 4.5.11 and 4.5.14


From: Martin Schwenke
Subject: [bug #45930] -ignore_readdir_race ineffective in find 4.5.11 and 4.5.14
Date: Tue, 17 Dec 2024 18:08:13 -0500 (EST)

Follow-up Comment #13, bug #45930 (group findutils):

[comment #11 comment #11:]
> Alright, that's yet another case than the already-fixed one.
> The fix for this one would look like the following.

> diff --git a/find/ftsfind.c b/find/ftsfind.c
> index 89ed9dd0..f57fa809 100644
> --- a/find/ftsfind.c
> +++ b/find/ftsfind.c
> @@ -304,6 +304,9 @@ consider_visiting (FTS *p, FTSENT *ent)
> }
> if (ent->fts_info == FTS_DNR)
> {
> +      /* Ignore ENOENT error for vanished directories.  */
> +      if (ENOENT == ent->fts_errno && options.ignore_readdir_race)
> +        return;
> nonfatal_target_file_error (ent->fts_errno, ent->fts_path);
> if (options.do_dir_first)
> {


> WDYT?

I just tested that change with the scenario in my previous comment and I still
see the issue.  I added some debug output (to stderr) before the new early
return but the debug output is never printed.  :-(

I had hoped to understand this and submit a patch myself, but understanding
FTS is difficult...


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?45930>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]