[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: double free error in gawk
From: |
Andrew J. Schorr |
Subject: |
Re: double free error in gawk |
Date: |
Thu, 2 Jul 2020 17:09:59 -0400 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Jul 02, 2020 at 12:30:14PM -0600, arnold@skeeve.com wrote:
> You are asking hard questions.
That's why you pay me the big bucks -- to ask the tough questions. :-)
> The code predates MPFR, which is
> the main problem. You want to keep most of the flags, such as
> NUMCUR and the non-MPFR numeric value if you've got it.
Agreed.
> It's at least STRING|STRCUR. And NUMCUR if you've got it, 'cause
> why not? I'd have to review the other flags to see what makes
> sense.
>
> Hmm, if MP* flags were set, then I should clear NUMCUR too. Yech.
Makes sense.
I'm just wondering about USER_INPUT, but I think it's probably OK to
copy that value as well, since it should be left on for numeric strings
and cleared only if it's non-numeric.
> One day I'll rewrite this in nicely object oriented C++ and it'll
> get cleaner. Maybe after we get World Peace.
Ha. I'm sure we all have bigger priorities than rewriting gawk.
Regards,
Andy