Re: [Bug-gcal] gcal and unicode

[Giuseppe Scrivano]

Hello Mariusz,

thanks to have reported it!  I am having problems to clone your git
repository, can you please send me the patch (as git format-patch) so I
can apply it?

I have looked at it and it does the right thing, so I will apply it.

Can you please update the NEWS file as well and amend this change to
your patch?

Cheers,
Giuseppe



Mariusz Adamski <address@hidden> writes:

> Hello,
>
> gcal seems to have a problem with unicode. On my locale (pl_PL.utf-8)
> gcal produces for example
>
> Grudzień 2010
>
> Niedziela           5 12 19 26   
> Poniedziałek       6 13 20 27   
> Wtorek              7 14 21 28   
> Środa           1  8 15 22 29   
> Czwartek         2  9 16 23 30   
> Piątek          3 10 17 24 31   
> Sobota           4 11 18 25
>
> (I hope you can notice a slight misalignment in the rows where week
> day name has a unicode character in it.) Also, with --type=special it
> prints
>
>     Grudzień 2010
>  Nd Pn WtŚr Cz Pt So
>            1  2  3  4
>   5  6  7  8  9 10 11
>
> (notice no space between Wt and Śr.)
>
> I've taken the liberty of setting-up a git branch on gitorious with my
> take on fixing this [1]. It's really quite trivial; boils down to
> replacing sprintf and strlen with unicode equivalents from gnulib. Adds
> about 37kB to the binary (stripped) when turned on.
>
> And on a totally unrelated topic to satisfy my curiosity: I noticed
> plenty of "#if USE_DE"'s in the sources; is it necessary in the advent
> of gettext? Or is it just a leftover baggage from ancient versions?
>
> Looking forward to your opinions. Kind regards
> -- Mariusz
>
> [1] http://gitorious.org/gnu-gcal-unicode