Re: [bug-gettext] [PATCH] Add a --disable-tools option

[Thomas Petazzoni]

Dear Stefano Lattarini,

On Tue, 28 May 2013 21:19:29 +0200, Stefano Lattarini wrote:

> I can't answer about that.  Maybe they have good reasons to do so,
> or maybe they too have just copied the idiom from other makefiles,
> that too have copied from other older makefiles, ...  You get the
> picture.
> 
> > What I did is the way that is documented in the automake documentation:
> > http://www.gnu.org/software/automake/manual/html_node/Subdirectories-with-AM_005fCONDITIONAL.html.
> >
> I think the example is in that form to minimize spurious difference
> with the following example "Subdirectories with AC_SUBST":
> http://www.gnu.org/software/automake/manual/html_node/Subdirectories-with-AC_005fSUBST.html
> 
> Anyway, what you did is *not wrong* -- I just suggested a briefer
> idiom to obtain the same effect.  I have no strong feelings in the
> issue, so if the Gettext maintainer can absolutely take your patch
> if he prefers.  No objection at all from me!

I think I thought the += construct would be preventing Automake from
inferring the value of DIST_SUBDIRS from SUBDIRS. But this magic is
smart enough to also handle the += construct (I've tested on a dummy
example).

So I guess it's a matter of taste. Let's see what the gettext
maintainer prefer. I can rework the patch if needed.

Thanks,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com